fix(#106): short hand view count parsing#107
Open
antoniojps wants to merge 1 commit intoSuspiciousLookingOwl:developmentfrom
Open
fix(#106): short hand view count parsing#107antoniojps wants to merge 1 commit intoSuspiciousLookingOwl:developmentfrom
antoniojps wants to merge 1 commit intoSuspiciousLookingOwl:developmentfrom
Conversation
Owner
|
Thanks for the PR. I thought about adding something like this before for view count and upload date. But I decided not to proceed with this because others might use the client with a different language, for example const client = new Client({
youtubeClientOptions: {
hl: "fr" // france
}
});If people do that, then the parser will not work properly, unless we include all parsers for every language available on YouTube, which I decided not to do since it will be out of this library's scope, and people will have to write their own parser for their language. |
Contributor
Author
|
This will only parse IF it matches the K/M/B pattern so in theory it should never break any other language. It will default to the parseInt otherwise. WDYT? (Otherwise shorts views are irrelevant) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue Shorts view count parsing - 20K views shows 20 views #106